On 24/04/2024 09:03, Johan Hovold wrote: > On Tue, Apr 23, 2024 at 06:24:39PM +0200, Krzysztof Kozlowski wrote: >> On 23/04/2024 15:46, Johan Hovold wrote: > >>> properties: >>> compatible: >>> - items: >>> - - const: elan,ekth6915 >>> + oneOf: >>> + - items: >>> + - enum: >>> + - elan,ekth5015m >>> + - const: elan,ekth6915 >>> + - items: >> >> Don't re-add the items for this entry. Just const. > > Sure. But note that the example schema uses 'items' like this (e.g. for > 'compatible' and 'clock-names'): > > https://docs.kernel.org/devicetree/bindings/writing-schema.html#annotated-example-schema > Yes, that's the inconsistency we keep. The point is that clocks usually have just one list, so one "items:". For compatible there can be many and it leads to less readable code, e.g.: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml?h=v6.9-rc5#n15 Best regards, Krzysztof
