On Wed, Apr 24, 2024 at 1:41 AM Aren Moynihan <aren@xxxxxxxxxxxxxxxxx> wrote: > > The stk3310 and stk3310 chips have an input for power to the infrared > LED. Add support for managing it's state. its ... > if (IS_ERR(data->vdd_reg)) > return dev_err_probe(&client->dev, ret, "get regulator vdd failed\n"); > > + data->led_reg = devm_regulator_get(&client->dev, "leda"); > + if (IS_ERR(data->led_reg)) > + return dev_err_probe(&client->dev, ret, "get regulator led failed\n"); Can't you use a bulk regulator API instead? -- With Best Regards, Andy Shevchenko