On 4/23/24 08:44, Rob Herring wrote: > On Mon, Apr 22, 2024 at 03:58:58PM -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx> >> --- >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> index 426f90a47f35..02315669b831 100644 >> --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> @@ -61,6 +61,14 @@ properties: >> interrupt-map: >> maxItems: 4 >> >> + phys: >> + maxItems: 4 >> + >> + phy-names: >> + maxItems: 4 >> + items: >> + - pattern: '^pcie-phy[0-3]$' > > The names here are pointless and redundant. Names are local to the > device, so 'pcie' is redundant. They only refer to PHYs, so 'phy' is > redundant too. All you are left with is the index of the entry. > > Now if PCIe can work on only lanes 2 and 3 or similar, then maybe > -names becomes useful. OK, I'll just remove them... --Sean
