On 23/04/2024 12:15, Andre Przywara wrote: > On Mon, 22 Apr 2024 17:45:10 +0100 > Andre Przywara <andre.przywara@xxxxxxx> wrote: > > Hi, > >> From: James McGregor <jamcgregor@xxxxxxxxxxxxxx> >> >> The Allwinner H616 SoC has an LRADC which is compatible with the >> versions in existing SoCs. >> Add a compatible string for H616, with the R329 fallback. This is the >> same as the D1, so put them into an enum. >> >> Signed-off-by: James McGregor <jamcgregor@xxxxxxxxxxxxxx> >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > > Compared the descriptions in the manual between the R392 and the H616, they > look the same: > > Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> Why do you review your own patches? Does it mean that you contribute code which you did not review before? This is odd process. Your Review is implied by sending the patch. And you have there SoB which indicates you sent it... Best regards, Krzysztof