Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/23/24 12:24 PM, Krzysztof Kozlowski wrote:
On 22/04/2024 14:21, Mohammad Shehar Yaar Tausif wrote:
Convert USB UHCI bindings to DT schema. Documenting aspeed compatibles
and missing properties. Adding aspeed/generic-uhci example and fix previous
incorrect example.

Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@xxxxxxxxx>

+required:
+  - compatible
+  - reg
+  - interrupts
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: generic-uhci
+    then:
+      $ref: usb-hcd.yaml

Nothing improved here.

Sorry, I could not understand this, please guide me about the correction required here. I added $ref inside the if-then block because it was raising errors when tested against dts files that used "platform-uhci" as the compatible. Putting it above the if block did
not work.

When I ref the usb-hcd.yaml, it also includes usb.yaml which requires the nodename to start with usb*, but the dtsi that use the deprecated compatible (arch/arm/boot/dts/vt8500/wm8505.dtsi) have their nodename with
uhci*, which causes the tests to fail.

+      required:
+        - clocks

And this was not tested.
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    uhci@d8007b00 {
+        compatible = "platform-uhci";

What happened here? This is deprecated!

The original example has the nodename as uhci* which causes the schema to fail as mentioned earlier. Should I just remove the example or should I rename the node here and add clock field to the original example ?

Best Regards,
Shehar




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux