On 4/19/24 8:55 AM, Krzysztof Kozlowski wrote:
On 19/04/2024 00:14, Judith Mendez wrote:
Update eQEP binding for TI K3 devices.
Here and in subject: everything is an update. Be specific.
A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Will fix, thanks.
Signed-off-by: Judith Mendez <jm@xxxxxx>
---
Documentation/devicetree/bindings/counter/ti-eqep.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
index 85f1ff83afe72..11755074c8a91 100644
--- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
+++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
@@ -14,19 +14,23 @@ properties:
const: ti,am3352-eqep
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
Why? This must be constrained. Devices either have 1 or 2, no both at
the same time.
Will fix for v2.
interrupts:
description: The eQEP event interrupt
maxItems: 1
clocks:
- description: The clock that determines the SYSCLKOUT rate for the eQEP
+ description: The clock that determines the clock rate for the eQEP
peripheral.
maxItems: 1
clock-names:
- const: sysclkout
+ maxItems: 1
NAK. That's just wrong, not explained at all either.
The intention was to make the binding a bit more generic, but I see
that is not the correct direction to go, thanks for the feedback.
~ Judith
Best regards,
Krzysztof
