On 22/04/2024 09:50, Mike Looijmans wrote: > On 15-04-2024 17:24, Krzysztof Kozlowski wrote: >> On 15/04/2024 10:13, Mike Looijmans wrote: >>> Another technology to store energy is a (super)capacitor. >>> >>> Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx> >>> --- >>> >>> (no changes since v1) >>> >>> Documentation/devicetree/bindings/power/supply/battery.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/supply/battery.yaml b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> index 491488e7b970..a22c97dfad88 100644 >>> --- a/Documentation/devicetree/bindings/power/supply/battery.yaml >>> +++ b/Documentation/devicetree/bindings/power/supply/battery.yaml >>> @@ -44,6 +44,7 @@ properties: >>> - const: lithium-ion-polymer >>> - const: lithium-ion-iron-phosphate >>> - const: lithium-ion-manganese-oxide >>> + - const: capacitor >> Please keep some sort of order... everyone insists on adding to the end >> of the lists... > > Could make it alphabetical, but that requires re-ordering the existing > ones so "lithium" sorts before "nickel". So just put it at beginning, less sorting later. > > I think the intention here was that the order is the same as the > matching defines in power-supply.h There is no such binding as power-supply.h. And other headers do not matter, they are not bindings. Best regards, Krzysztof
