On 20/04/2024 16:21, Mohammad Shehar Yaar Tausif wrote: > Convert USB UHCI bindings to DT schema > > Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@xxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml > new file mode 100644 > index 000000000000..511c3ecd8d53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/usb-uhci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Platform UHCI Controller > + > +allOf: > + - $ref: usb-hcd.yaml# > + > +maintainers: > + - Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + const: generic-uhci You missed deprecated compatible. Also missed Aspeed compatibles. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts Please confirm that you tested DTS. > + > +unevaluatedProperties: false > + > +examples: > + - | > + usb@d8007b00 { > + compatible = "generic-uhci"; Use 4 spaces for example indentation. Best regards, Krzysztof
