On Tue, Feb 17, 2015 at 01:11:12PM +0100, Geert Uytterhoeven wrote:
> - Does there exist any regulator notifier event that corresponds to
> DA9210_E_VMAX?
What does that mean, I might be able to tell you? I guess it might be
an over voltage event...
> + error = regmap_read(chip->regmap, DA9210_REG_EVENT_B, &val);
> + if (error < 0)
> + goto error_i2c;
...
> + if (val) {
> + /* Clear all events */
> + error = regmap_write(chip->regmap, DA9210_REG_EVENT_B, val);
> + if (error < 0)
> + goto error_i2c;
> +
> + ret = IRQ_HANDLED;
> + }
It's generally better to only acknowledge unmasked sources for
defensiveness and improved diagnostics. Not super critical though.
Attachment:
signature.asc
Description: Digital signature
