On 19/04/2024 10:31, Holger Assmann wrote: > This is an optional property. If set, the pca9450 will be registered as > a reset device with the chosen priority level. > > Signed-off-by: Holger Assmann <h.assmann@xxxxxxxxxxxxxx> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > --- > .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > index 3d469b8e97748..7cc2d6636cf52 100644 > --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml > @@ -35,6 +35,9 @@ properties: > interrupts: > maxItems: 1 > > + priority: > + $ref: /schemas/power/reset/restart-handler.yaml# You defined object, which is not explained in commit msg. This code does not look correct or it does not implement what you said. Please look at existing code - do you see anything like this? No, there is no such code and this should raise question. You probably want to annotate that device is a restart handler? Best regards, Krzysztof
