On 19/04/2024 14:45, Konstantin Pugin wrote: > From: Konstantin Pugin <ria.freelander@xxxxxxxxx> > > Add EXAR XR20M1172 UART compatible line into devicetree documentation. > > Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx> > Signed-off-by: Konstantin Pugin <ria.freelander@xxxxxxxxx> > --- > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.ya This is fourth change, no cover letter, no changelog. Patch is trivial but you do not make it easier to understand what is happening here. Please provide proper changelog under ---. (If you wrote changelog somewhere else and then decided not to send it to us, it is like there was no changelog. I literally do not have it in my inbox). Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof