On Thu, Apr 18, 2024 at 04:43:54PM +0100, Conor Dooley wrote: > On Thu, Apr 18, 2024 at 02:11:06PM +0200, Marek Behún wrote: > > Add binding for cznic,turris-omnia-mcu, the device-tree node > > representing the system-controller features provided by the MCU on the > > Turris Omnia router. > > > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > .../bindings/arm/cznic,turris-omnia-mcu.yaml | 86 +++++++++++++++++++ > > Why's this in bindings/arm btw? Seems like it is some remote firmware if > it is running off-SoC on an MCU, so either remoteproc or firmware would > make more sense? Tying it to arm at least needs an explanation IMO. This was discussed with Krzysztof in v1, you can look it up at https://lore.kernel.org/soc/20230824131736.067c40e2@dellmb/ Basically the SoC is an ARM board, and the MCU is also always ARM. I'm guessing firmware would also make sense...