On Thu, Apr 18, 2024 at 10:16:50AM -0500, Rob Herring wrote: > On Wed, Apr 17, 2024 at 11:49:57PM +0100, Andre Przywara wrote: > > On Wed, 17 Apr 2024 12:04:22 -0500 > > Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > > > Hi, > > > > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > > > Add support for the GPADC for the Allwinner H616. It is identical to > > > the existing ADC for the D1/T113s/R329/T507 SoCs. > > > > The H616 is using the same die as the T507 and the H700, and since the > > T507 is already mentioned in the commit message for the original > > binding, I wonder if we actually need a new compatible? > > For same die, I would say no you don't. But adding a compatible is fine, > too. > > Rob I've been burned before, if it's just the same to you I'd like to do a compatible. But I will defer to the experts on this matter. Also if there is a more compact way of expressing this while still maintaining backwards compatibility please let me know. Otherwise, I'm okay with this if you all are (it passes dt_binding_check, yamllint, and checkpatch.pl so I'm okay with it if you are). Chris
