On Wed, Apr 17, 2024 at 07:20:31PM +0200, Francesco Dolcini wrote:
> Hello Frank,
>
> On Wed, Apr 17, 2024 at 12:01:43PM -0400, Frank Li wrote:
> > On Tue, Apr 16, 2024 at 08:50:26AM +0200, Francesco Dolcini wrote:
> > > On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> > > > Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > > > ---
> > > > arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
> > > > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 86 ++++
> > > > 2 files changed, 559 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> > > > new file mode 100644
> > > > index 0000000000000..ed5a1b4af1d76
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
>
> ...
>
> > > > +/delete-node/ &acm;
> > > > +/delete-node/ &sai4;
> > > > +/delete-node/ &sai5;
> > > > +/delete-node/ &sai4_lpcg;
> > > > +/delete-node/ &sai5_lpcg;
> > >
> > > Can you explain these delete-node ? This is something that I would
> > > expect when a dtsi is previously included, not in this case.
> >
> > We want to avoid some property inherent from parent dtsi file because it is
> > big difference with common one.
> >
> > This node will be rewrite totally in this files.
>
> imx8qm-ss-audio.dtsi does not include any file. From where these
> inherited properties are coming from? Which file is the "parent dtsi" ?
imx8qm-ss-audio.dtsi are not supposed to be included directly. imx8qm.dtsi
is supposed to be included by other board dts file.
in imx8qm.dtsi
/* sorted in register address */
+ #include "imx8-ss-audio.dtsi"
#include "imx8-ss-vpu.dtsi"
#include "imx8-ss-img.dtsi"
#include "imx8-ss-dma.dtsi"
@@ -473,3 +558,4 @@ drc_crit0: trip1 {
#include "imx8qm-ss-dma.dtsi"
#include "imx8qm-ss-conn.dtsi"
#include "imx8qm-ss-lsio.dtsi"
+#include "imx8qm-ss-audio.dtsi"
"imx8qm-ss-audio" will overwrite some common audio node in
"imx8-ss-audio.dtsi"
acm, and sai4/5 are defined in imx8-ss-audio.dtsi for common part for all
imx8qm\imx8qxp\imx8dxl.
Frank
>
> Thanks,
> Francesco
>
