On Wed, Apr 17, 2024 at 12:15:57PM +0000, Peng Fan wrote: > Hi Dan, > > > Subject: Re: [PATCH v10 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol > > protocol basic support > > > > I'm trying to re-base AKASHI Takahiro's gpio driver on top of your scmi pinctrl > > driver. > > https://lore.ke/ > > rnel.org%2Fall%2F20231005025843.508689-1- > > takahiro.akashi%40linaro.org%2F&data=05%7C02%7Cpeng.fan%40nxp.com% > > 7C342dd6eb0463456d0d6608dc5e41de1c%7C686ea1d3bc2b4c6fa92cd99c5 > > c301635%7C0%7C0%7C638488884186606528%7CUnknown%7CTWFpbGZs > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > > 0%3D%7C0%7C%7C%7C&sdata=DMJZ2uwuJigkEnEcY7JdBw6DMPjHxcUvvh7 > > 2fsaep50%3D&reserved=0 > > I need to do something like this below to save the gpio information. > > > > So now, great, I have the information but I'm not sure how to export it from > > the scmi pinctrl driver to the gpio driver... (This is a probably a stupid > > question but I am real newbie with regards to gpio). > > > > The other thing is that the SCMI spec says: > > > > 4.11.2.7 > > PINCTRL_SETTINGS_GET > > > > This command can be used by an agent to get the pin or group > > configuration, and the function selected to be enabled. It can also > > be used to read the value of a pin when it is set to GPIO mode. > > > > What does that mean? Is that right, or is it something left over from a > > previous revision of the spec. > > > > regards, > > dan carpenter > > > > diff --git a/drivers/firmware/arm_scmi/pinctrl.c > > b/drivers/firmware/arm_scmi/pinctrl.c > > Just a short question, you will make this a standalone > patch part of your gpio pinctrl patchset, right? > > Or you wanna include this change in my v11 patch? > > I hope v11 + imx oem patches could land in 6.10, > so I would not expect big changes to v11. Yeah. Let's get your patches merged. I don't think there is anything in mine which conflict with yours. It's just addon. regards, dan carpenter
