On Sun, 14 Apr 2024 11:07:19 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
Hi Krzysztof,
> On 14/04/2024 10:33, Ryan Walklin wrote:
> > From: Ryan Walklin <ryan@xxxxxxxxxxxxx>
> >
> > RG35XX 2024: Base version with Allwinner H700
> > RG35XX Plus: Adds Wifi/BT
> > RG35XX H: Adds second USB port and analog sticks to -Plus in horizontal
> > altered form factor,
> >
> > Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/sunxi.yaml | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index 09d835db6db5..fc10f54561c9 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -56,6 +56,21 @@ properties:
> > - const: anbernic,rg-nano
> > - const: allwinner,sun8i-v3s
> >
> > + - description: Anbernic RG35XX (2024)
> > + - items:
> > + - const: anbernic,rg35xx-2024
> > + - const: allwinner,sun50i-h700
> > +
> > + - description: Anbernic RG35XX Plus
> > + - items:
> > + - const: anbernic,rg35xx-plus
> > + - const: allwinner,sun50i-h700
> > +
> > + - description: Anbernic RG35XX H
> > + - items:
> > + - const: anbernic,rg35xx-h
>
> Any reason these are not just one enum with three entires?
I think the policy in *this* file is one entry for each device, so that we
can attribute a device name ("Anbernic RG35XX H") to the compatible string.
I mean otherwise we could group all H616 boards for instance into one
entry. Don't know if this is what we want?
Cheers,
Andre
