> It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > No uppercase letters are allowed as node names. Apologies, this was my omission. > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > Noted, thanks. >> + >> + reg_vcc5v: vcc5v { > > Use some common reasonable prefix, e.g. regulator > Noted, thanks. > Please do not add dead code without explanation. Noted, thanks. Regards, Ryan
