On Fri, Apr 12, 2024 at 11:42:08AM -0400, Frank Li wrote: > Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need > it. EDMA supports each power-domain for each dma channel. So minItems and > maxItems align 'dma-channels'. > > Change fsl,imx93-edma3 example to fsl,imx8qm-edma to reflect this variants. > > Fixed below DTB_CHECK warning: > dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > > Notes: > Change from v3 to v4 > - Remove 'contains' change should be belong to first patch when rebase. > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/dma/fsl,edma.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb > > After this patch no warning for imx8dxl-evk.dtb. > > touch arch/arm64/boot/dts/freescale/imx8dxl.dtsi > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8dxl-evk.dtb > DTC_CHK arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb > > Change from v2 to v3 > - set 'power-domains' false for other compatitble string > - change imx93 example to 8qm example to affect this change according to > Krzysztof Kozlowski's suggestion, choose least channel number edma > instance to reduce code copy. max channel number is 64. > > - Rebase to latest dmaengine/next, fixes conflicts. > > Change from v1 to v2 > - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel. > - add power-domains to 'required' when compatible string is fsl,imx8qm-adma > or fsl,imx8qm-edma > > .../devicetree/bindings/dma/fsl,edma.yaml | 77 ++++++++++--------- > 1 file changed, 39 insertions(+), 38 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > index fb5fbe4b9f9d4..012522612dc96 100644 > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > @@ -71,6 +71,10 @@ properties: > minItems: 1 > maxItems: 33 > > + power-domains: > + minItems: 1 > + maxItems: 64 Please state here that number of power-domains are equal to number of channels and in ascending order. Rob