On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > --- > #include <dt-bindings/mfd/qcom-rpm.h> > @@ -66,5 +237,18 @@ frequencies. > > #address-cells = <1>; > #size-cells = <0>; > + > + pm8921_smps1: pm8921-smps1 { > + compatible = "qcom,rpm-pm8921-smps"; > + reg = <QCOM_RPM_PM8921_SMPS1>; > + > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + regulator-always-on; > + > + bias-pull-down; > + > + qcom,switch-mode-frequency = <3200000>; > + }; > }; My only comment here is that most (all but one) of the other mfd regulator devices use regulators {}. Still wonder if that's what we should do. Otherwise, Reviewed-by: Andy Gross <agross@xxxxxxxxxxxxxx> -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html