On 4/12/24 14:36, Fenglin Wu via B4 Relay wrote:
From: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
Add support for a new SPMI vibrator module which is very similar
to the vibrator module inside PM8916 but has a finer drive voltage
step and different output voltage range, its drive level control
is expanded across 2 registers. The vibrator module can be found
in following Qualcomm PMICs: PMI632, PM7250B, PM7325B, PM7550BA.
Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
---
[...]
+ if (regs->drv2_mask) {
+ if (on)
+ val = (vib->level << regs->drv2_shift) & regs->drv2_mask;
The point of regmap_foo_bits is that you no longer need to mask the
value here.
+ else
+ val = 0;
+
You can also save some LoC without compromising on legibility:
if (regs->drv2_mask) {
val = vib->level << regs->drv2_shift;
rc = regmap_write_bits(vib->regmap, vib->drv2_addr,
regs->drv2_mask, on ? val : 0)
if (rc < 0)
return rc;
}
Konrad
