Re: [PATCH v3 07/10] dt-bindings: iio: dac: add docs for AD9739A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/15/24 7:25 AM, Nuno Sá wrote:
> On Fri, 2024-04-12 at 18:47 -0500, David Lechner wrote:
>> On Fri, Apr 12, 2024 at 8:36 AM Nuno Sa via B4 Relay
>> <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote:
>>>
>>> From: Nuno Sa <nuno.sa@xxxxxxxxxx>
>>>
>>
>> ...
>>
>>> +  adi,full-scale-microamp:
>>> +    description: This property represents the DAC full scale current.
>>
>> The description could be improved by saying what determines the value
>> that need to be entered here. (Also wondering if this is not something
>> that should be set at runtime using the _scale attribute instead.)
>>
> 
> Hmm, not sure what you mean here? For anyone using a device like this, it should
> be clear what this is about :)

I never used a part like this before, but Jonathan explained it in his
reply to my comments on the LTC2672 bindings. It does sound like this
is a common property.

> 
>>> +    minimum: 8700
>>> +    maximum: 31700
>>
>> Missing a default value since this is not a required property?
>>
> 
> Hmm, yes. That could definitely be added.
> 
> - Nuno Sá
>>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux