Hello, On Mon, Apr 15, 2024 at 12:03:26PM +0530, Udit Kumar wrote: > Updating J784S4 macro for pin mux instead of J721S2. > > Also arranging pin mux in order of main_pmx0/1, wkup_pmx0/1/2/3 > along with fixing pin type for TX as output of wkup_uart. Are you doing a refactoring + fixes in the same commit or I misunderstood your commit message? If this is the case I would suggest to have separate commit for the fix and the refactoring, with the fix being first in the series and with a fixes tag. >From a quick look, this comment may apply to other commits in the series. Thanks, Francesco
