On 14/04/2024 17:22, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek <david@xxxxxxxxxxxxxx> > --- > .../bindings/display/panel/raydium,rm69380.yaml | 94 ++++++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > new file mode 100644 > index 000000000000..9b01b9c22ae9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Raydium RM6380-based DSI display panels > + > +maintainers: > + - David Wronek <david@xxxxxxxxxxxxxx> > + > +description: > + The Raydium RM69380 is a generic DSI Panel IC used to control > + OLED panels. > + > +properties: > + compatible: > + items: > + - const: lenovo,j716f-edo-rm69380 > + - const: raydium,rm69380 > + > + avdd-supply: > + description: Analog voltage rail > + > + vddio-supply: > + description: I/O voltage rail > + > + reset-gpios: > + maxItems: 1 > + > + reg: true > + > +required: > + - compatible > + - reg > + - avdd-supply > + - vddio-supply > + - reset-gpios > + > +allOf: > + - $ref: panel-common-dual.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - lenovo,j716f-edo-rm69380 You have only one variant, so entire if: is not needed. Just require ports in top-level, if you say this device cannot support single-link (just to remind: we talk about what device supports, not driver). > + then: > + properties: > + port: false Redundant, drop. > + ports: > + required: > + - port@1 > + Best regards, Krzysztof
