On 14/04/2024 15:56, Jonas Karlman wrote: > Hi Krzysztof, > > On 2024-04-14 15:33, Krzysztof Kozlowski wrote: >> On 14/04/2024 15:15, Jonas Karlman wrote: >>> The Radxa ZERO 3W/3E is an ultra-small, high-performance single board >>> computer based on the Rockchip RK3566, with a compact form factor and >>> rich interfaces. >>> >>> The ZERO 3W and ZERO 3E are basically the same size and model, but >>> differ only in storage and network interfaces. >>> >>> - eMMC (3W) >>> - SD-card (both) >>> - Ethernet (3E) >>> - WiFi/BT (3W) >>> >>> This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB. >>> >>> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx> >>> --- >>> .../dts/rockchip/rk3566-radxa-zero-3e.dts | 41 ++ >>> .../dts/rockchip/rk3566-radxa-zero-3w.dts | 26 + >>> .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++ >>> 3 files changed, 510 insertions(+) >> >> How do you build your patches? That's rhetorical, because they cannot be >> built... Missing Makefile. > > They where built using the generic .dtb-file make target, will include > in Makefile in v2, thanks. > >> >> Are you sure therefore that your dts pass dtbs_check? If this is not in >> Makefile, how did you run the command? > > I built and tested dts files using the following make commands: > > make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 defconfig > make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 CHECK_DTBS=y rockchip/rk3566-radxa-zero-3w.dtb > make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 CHECK_DTBS=y rockchip/rk3566-radxa-zero-3e.dtb OK, thanks, wasn't sure it works without makefile. Anyway you still need it. Best regards, Krzysztof