On Sat, 13 Apr 2024 15:56:08 +0200, Etienne Buira wrote: > rockchip,rk3328-grf-gpio is handled as syscon, but syscon mandates > presence of gpio,syscon-dev node (or it will call dev_err() when probed). > Correct rk3328.dtsi and related documentation to follow syscon's > expectations. > > Signed-off-by: Etienne Buira <etienne.buira@xxxxxxx> > --- > .../devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml | 2 ++ > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + > 2 files changed, 3 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.example.dtb: gpio: 'gpio,syscon-dev' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/rockchip,rk3328-grf-gpio.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ZhqO-DEmh-6TeHrt@Z926fQmE5jqhFMgp6 The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
