On 13/04/2024 15:56, Etienne Buira wrote: > rockchip,rk3328-grf-gpio is handled as syscon, but syscon mandates syscon does not need such property. I see it in gpio-syscon, but not in syscon. > presence of gpio,syscon-dev node (or it will call dev_err() when probed). > Correct rk3328.dtsi and related documentation to follow syscon's > expectations. No, look at gpio-syscon driver. Parent is used. > > Signed-off-by: Etienne Buira <etienne.buira@xxxxxxx> > --- > .../devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml | 2 ++ Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml > index d8cce73ea0ae..2c878e7db900 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml > @@ -38,6 +38,7 @@ required: > - compatible > - gpio-controller > - "#gpio-cells" > + - gpio,syscon-dev No, not needed. And also incomplete - where is the property defined? It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
