On Thu, Apr 11, 2024 at 09:59:35PM +0200, Krzysztof Kozlowski wrote: > On 10/04/2024 04:20, Ondřej Jirman wrote: > > On Mon, Apr 08, 2024 at 10:12:30PM GMT, Krzysztof Kozlowski wrote: > >> On 08/04/2024 17:17, Ondřej Jirman wrote: > >>> > >>> Now for things to not fail during suspend/resume based on PM callbacks > >>> invocation order, anx7688 driver needs to enable this regulator too, as long > >>> as it needs it. > >> > >> No, the I2C bus driver needs to manage it. Not one individual I2C > >> device. Again, why anx7688 is specific? If you next phone has anx8867, > >> using different driver, you also add there i2c-supply? And if it is > >> nxp,ptn5100 as well? > > > > Yes, that could work, if I2C core would manage this. > > Either I don't understand about which I2C regulator you speak or this is > not I2C core regulator. This is a regulator to be managed by the I2C > controller, not by I2C core. If it is a supply that pulls up the SDA/SCL lines, then it is generic enough to be handled by the core. For example, on Qualcomm platforms CCI lines also usually have external supply as a pull-up. -- With best wishes Dmitry
