On 11/04/2024 14:21, Bryan O'Donoghue wrote: > On 11/04/2024 13:03, Krzysztof Kozlowski wrote: >> On 11/04/2024 10:52, Vladimir Zapolskiy wrote: >>> This reverts commit 3e383dce513f426b7d79c0e6f8afe5d22a581f58. >>> >>> The commit ae2a1f0f2cb5 ("dt-bindings: i2c: qcom-cci: Document sc8280xp compatible") >>> was correct apparently, it is required to describe the sc8280xp-cci >>> controller properly, as well it eliminates dtbs_check warnings. >>> >>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> >> >> Subject: >> dt-bindings: i2c: Revert .... >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> Best regards, >> Krzysztof > > Reversion is not the right fix. > > I'll send a proper fix asap. > > cci0: cci@ac4a000 { > compatible = "qcom,sc8280xp-cci", "qcom,msm8996-cci"; > > clock-names = "camnoc_axi", > "slow_ahb_src", > "cpas_ahb", So this patch was not tested? Un-reviewed.... I complain a lot that people from various companies send untested patches, but it seems Linaro does the same. That does not make me happy :/ Best regards, Krzysztof