On Thu, Apr 11, 2024 at 4:26 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 11/04/2024 11:16, Binbin Zhou wrote: > > Add Loongson PWM controller binding with DT schema format using > > json-schema. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > > > > +properties: > > + compatible: > > + oneOf: > > + - const: loongson,ls7a-pwm > > + - items: > > + - enum: > > + - loongson,ls2k0500-pwm > > + - loongson,ls2k1000-pwm > > + - loongson,ls2k2000-pwm > > + - const: loongson,ls7a-pwm > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + '#pwm-cells': > > + description: > > + The first cell must have a value of 0, which specifies the PWM output signal; > > If you have always the same value in PWM phandle, why encoding it in the > phandle in the first place? What's the benefit of passing 0? Hi Krzysztof: My thoughts are: First of all, our pwm has only one output signal, so it can only be 0. Also, as you know from the pwm xlate function, the first cell is the pwm index, so I fixed it to be 0 here. The xlate function: https://elixir.bootlin.com/linux/v6.8/source/drivers/pwm/core.c#L106 Thanks. Binbin > > > + The second cell is the period in nanoseconds; > > + The third cell flag supported by this binding is PWM_POLARITY_INVERTED. > > + const: 3 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + > > +additionalProperties: false > > + > > > Best regards, > Krzysztof >
