> Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension > protocol > > On Fri, Apr 05, 2024 at 08:39:24PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > Add i.MX SCMI Extension protocols bindings for: > > - Battery Backed Secure Module(BBSM) > > - MISC settings such as General Purpose Registers settings. > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > .../devicetree/bindings/firmware/imx,scmi.yaml | 80 > ++++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml > > b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml > > new file mode 100644 > > index 000000000000..7ee19a661d83 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml > > @@ -0,0 +1,80 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2024 > > +NXP %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Ffirmware%2Fimx%2Cscmi.yaml%23&data=05%7 > C02%7Cp > > > +eng.fan%40nxp.com%7C25c72418c9864a73924808dc59826288%7C686ea > 1d3bc2b4c > > > +6fa92cd99c5c301635%7C0%7C0%7C638483663734828123%7CUnknown% > 7CTWFpbGZsb > > > +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > 0%3D > > > +%7C0%7C%7C%7C&sdata=Y2uSGDorqR9HK8PO4AQDQ%2FaTv%2BETnulvU > C8u9ktDoio%3 > > +D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fmeta- > schemas%2Fcore.yaml%23&data=05%7C02%7Cpeng.fan%40nx > > > +p.com%7C25c72418c9864a73924808dc59826288%7C686ea1d3bc2b4c6fa > 92cd99c5c > > > +301635%7C0%7C0%7C638483663734841350%7CUnknown%7CTWFpbGZs > b3d8eyJWIjoiM > > > +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7 > C%7C%7 > > > +C&sdata=h6lSgnPvR88CEBxmU%2B%2FCfCx9GHUrogWVxck38sIdhB4%3D&r > eserved=0 > > + > > +title: i.MX System Control and Management Interface(SCMI) Vendor > > +Protocols Extension > > + > > +maintainers: > > + - Peng Fan <peng.fan@xxxxxxx> > > + > > +allOf: > > + - $ref: arm,scmi.yaml# > > This needs to be the other way around. Add a ref to this file in arm,scmi.yaml > under an 'anyOf' entry. ok, I will give a try. > > > + > > +properties: > > + protocol@81: > > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > > + unevaluatedProperties: false > > + description: > > + The BBM Protocol is for managing Battery Backed Secure Module > (BBSM) RTC > > + and the ON/OFF Key > > + > > + properties: > > + reg: > > + const: 0x81 > > + > > + required: > > + - reg > > + > > + protocol@84: > > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > > + unevaluatedProperties: false > > + description: > > + The MISC Protocol is for managing SoC Misc settings, such as > > + GPR settings > > + > > + properties: > > + reg: > > + const: 0x84 > > + > > + wakeup-sources: > > + description: > > + Each entry consists of 2 integers, represents the source and electric > signal edge > > + items: > > + items: > > + - description: the wakeup source > > + - description: the wakeup electric signal edge > > No constraints on the entry values? I will change the property name to imx,wakup-sources with constraints minItems: 1 maxItems: 32. > > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + > > + required: > > + - reg > > + > > +additionalProperties: false > > And then this can be true. Fix in v3. Thanks Peng. > > Rob
