On Wed, Apr 10, 2024 at 08:15:19PM +0200, Krzysztof Kozlowski wrote: > MT7621 PCI host bridge has children which apparently are also PCI host > bridges, at least that's what the binding suggest. What does it even mean for a PCI host bridge to have a child that is also a PCI host bridge? Does this mean a driver binds to the "parent" host bridge, enumerates the PCI devices below it, and finds a "child" host bridge? > The children have > "reg" property, but do not explicitly define it. Instead they rely on > pci-bus.yaml schema, but that one has "reg" without any constraints. > > Define the "reg" for the children, so the binding will be more specific > and later will allow dropping reference to deprecated pci-bus.yaml > schema. > > Acked-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changes in v2: > 1. Add tags. > --- > .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > index e63e6458cea8..61d027239910 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > @@ -36,6 +36,9 @@ patternProperties: > $ref: /schemas/pci/pci-bus.yaml# > > properties: > + reg: > + maxItems: 1 > + > resets: > maxItems: 1 > > -- > 2.34.1 >
