On Wed, Apr 10, 2024 at 1:00 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 10/04/2024 19:48, Rob Herring wrote: > > On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote: > >> dtschema package with core schemas deprecated pci-bus.yaml schema in > >> favor of pci-host-bridge.yaml. Update all bindings to use the latter > >> one. > >> > >> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in > >> lack of "reg" property defined by the latter, which should not have any > >> effect here, because all these bindings define the "reg". > >> > >> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml > >> binding which have children nodes being also host bridges, apparently. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +- > >> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++-- > >> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +- > >> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +- > >> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +- > >> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +- > >> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +- > >> 25 files changed, 26 insertions(+), 26 deletions(-) > > > > > >> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> index 61d027239910..5bbb4a3f3dbd 100644 > >> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml > >> @@ -14,7 +14,7 @@ description: |+ > >> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link > >> > >> allOf: > >> - - $ref: /schemas/pci/pci-bus.yaml# > >> + - $ref: /schemas/pci/pci-host-bridge.yaml# > >> > >> properties: > >> compatible: > >> @@ -33,7 +33,7 @@ properties: > >> patternProperties: > >> '^pcie@[0-2],0$': > >> type: object > >> - $ref: /schemas/pci/pci-bus.yaml# > >> + $ref: /schemas/pci/pci-host-bridge.yaml# > > > > I think this one should be pci-pci-bridge.yaml instead since it says > > these are root ports and based on the unit-address here. > > I was thinking about this as well, but pci-pci-bridge.yaml defines > compatible which is not present here at all. Since you suggest pci-pci, > I'll go with this and make it a separate patch for easier review. This was my concern at first. It does define compatible, but it doesn't require it. So I think we are fine. Rob
