Re: [PATCH v4 04/18] ASoC: mediatek: mt8195: Migrate to mtk_soundcard_common_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09/04/2024 13:32, AngeloGioacchino Del Regno wrote:
@@ -29,6 +30,13 @@
  #define RT1019_SPEAKER_AMP_PRESENT		BIT(1)
  #define MAX98390_SPEAKER_AMP_PRESENT		BIT(2)
+#define DUMB_CODEC_INIT BIT(0)
+#define MT6359_CODEC_INIT			BIT(1)
+#define RT1011_CODEC_INIT			BIT(2)
+#define RT1019_CODEC_INIT			BIT(3)
+#define MAX98390_CODEC_INIT			BIT(4)
+#define RT5682_CODEC_INIT			BIT(5)
+

Why are you using defines+single variable to track inited parts in the probe function but do it in the different way for legacy_probe using bool: is5682s, init6359 ? AFAII, both can use the same method with the defines above.

  #define RT1011_CODEC_DAI	"rt1011-aif"
  #define RT1011_DEV0_NAME	"rt1011.2-0038"
  #define RT1011_DEV1_NAME	"rt1011.2-0039"

--
Regards,
Alexandre




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux