On Di, 2024-04-09 at 19:27 -0700, Stephen Boyd wrote: > Quoting Conor Dooley (2024-04-09 05:05:37) > > On Mon, Apr 08, 2024 at 06:05:51PM +0100, Conor Dooley wrote: > > > > > > > Seconded, the clk-mpfs/reset-mpfs and clk-starfive-jh7110-sys/reset- > > > > > starfive-jh7110 drivers are examples of this. > > > > > > > > > > > The auxiliary device creation function can also be in the > > > > > > drivers/reset/ directory so that the clk driver calls some function > > > > > > to create and register the device. > > > > > > > > > > I'm undecided about this, do you think mpfs_reset_controller_register() > > > > > and jh7110_reset_controller_register() should rather live with the > > > > > reset aux drivers in drivers/reset/ ? > > > > > > > > Yes, and also mpfs_reset_read() and friends. We should pass the base > > > > iomem pointer and parent device to mpfs_reset_adev_alloc() instead and > > > > then move all that code into drivers/reset with some header file > > > > exported function to call. That way the clk driver hands over the data > > > > without having to implement half the implementation. > > > > > > I'll todo list that :) > > > > Something like the below? > > > > -- >8 -- > > From a12f281d2cb869bcd9a6ffc45d0c6a0d3aa2e9e2 Mon Sep 17 00:00:00 2001 > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Date: Tue, 9 Apr 2024 11:54:34 +0100 > > Subject: [PATCH] clock, reset: microchip: move all mpfs reset code to the > > reset subsystem > > > > <insert something here> > > > > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Looks pretty good. Yes, that does look convincing. regards Philipp
