On Tue, 9 Apr 2024 14:16:21 -0700 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Tue, 09 Apr 2024 17:04:03 +0200 Kory Maincent wrote: > > -static inline struct pse_control *of_pse_control_get(struct device_node > > *node) +static inline struct pse_control *of_pse_control_get(struct device > > *dev, > > + struct device_node > > *node) > > One of the related patches breaks the build: > > drivers/net/mdio/fwnode_mdio.c: In function ‘fwnode_find_pse_control’: > drivers/net/mdio/fwnode_mdio.c:32:35: error: passing argument 1 of > ‘of_pse_control_get’ from incompatible pointer type > [-Werror=incompatible-pointer-types] 32 | psec = > of_pse_control_get(np); | ^~ | > | | struct device_node > * In file included from drivers/net/mdio/fwnode_mdio.c:13: > ./include/linux/pse-pd/pse.h:157:69: note: expected ‘struct device *’ but > argument is of type ‘struct device_node *’ 157 | static inline struct > pse_control *of_pse_control_get(struct device *dev, | > ~~~~~~~~~~~~~~~^~~ > drivers/net/mdio/fwnode_mdio.c:32:16: error: too few arguments to function > ‘of_pse_control_get’ 32 | psec = of_pse_control_get(np); | > ^~~~~~~~~~~~~~~~~~ In file included from > drivers/net/mdio/fwnode_mdio.c:13: ./include/linux/pse-pd/pse.h:157:35: note: > declared here 157 | static inline struct pse_control > *of_pse_control_get(struct device *dev, | > ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Arg, a leftover of an old version of the series. Thanks for the report. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
