Hi Udit,
On 10/04/24 10:42, Kumar, Udit wrote:
Hi Neha
On 3/26/2024 5:57 PM, Neha Malcom Francis wrote:
Add the WKUP ESM instance for J721E. It has three instances in total,
one in the MAIN domain (main_esm) and two in the MCU-WKUP domain
(mcu_esm and wkup_esm).
Signed-off-by: Neha Malcom Francis <n-francis@xxxxxx>
---
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index 4618b697fbc4..b0f41e9829cc 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -689,4 +689,9 @@ mcu_esm: esm@40800000 {
ti,esm-pins = <95>;
bootph-pre-ram;
};
+
+ wkup_esm: esm@42080000 {
+ compatible = "ti,j721e-esm";
+ reg = <0x00 0x42080000 0x00 0x1000>;
I think , only esm@40800000 should be good for this SOC.
I am not sure, why you want to add this. If you still want to add this for
completeness ,
Yes, I wanted to make sure all ESM modules are present for DTS completeness.
then two options, I suggest
1) If you plan to use this mention bootph-pre-ram and ti,esm-pins
No plans for using it as of now.
J721E ESM interrupt routing is such that the MAIN_ESM interrupt triggers an
error event in the MCU_ESM (which is correctly set via their node ti,j721e-esm
glue logic pins). The MCU_ESM and WKUP_ESM both generate the same interrupt
after. So there is no ti,j721e-esm pin applicable for WKUP_ESM.
2) In case , no plan to use this then please mark node as disabled
Yes I will mark this as disabled, I overlooked the fact that leaving this
enabled would throw "ESM init failed" when DT syncs with U-Boot. Thanks for
catching!
+ };
};
--
Thanking You
Neha Malcom Francis
