On 09:45-20240404, Francesco Dolcini wrote:
> Hello Michael,
>
> On Wed, Apr 03, 2024 at 12:23:02PM +0200, Michael Walle wrote:
> > The J722S EVM has an on-board eMMC. Enable the SDHC interface for it.
> > There is no pinmuxing required because the interface has dedicated pins.
> >
> > Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>
> > ---
> > v2:
> > - move status="okay" last
> > ---
> > arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > index cee3a8661d5e..6b148da2bcdc 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > @@ -369,6 +369,13 @@ partition@3fc0000 {
> >
> > };
> >
> > +&sdhci0 {
> > + ti,driver-strength-ohm = <50>;
>
> According to the latest DTS coding style guidelines this needs to be
> just before status.
>
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
>
> Yes, we would need a checker, I know and I agree. At least now we moved
> out of the tribal knowledge way of working with every maintainer having
> slightly different expectation on this topic ... one step at a time :-)
Since this is the first cycle, I have done this fixup locally.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
