On Tue, Apr 09, 2024 at 05:09:35PM +0200, Alexander Sverdlin wrote: > Hi Nikita, > > On Tue, 2024-04-09 at 14:48 +0300, Nikita Shubin wrote: > > On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote: > > > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay > > > wrote: > > > > The goal is to recieve ACKs. > > > > > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus > > > portion. Who is gonna give you an Ack for that portion? If you > > > intended > > > maintaining that driver, should you not add a MAINTAINERS entry for > > > it? > > > > drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander > > Sverdlin. > > > > Arnd, Alexander - should we add it now ? > > seems that we have couple of things to fix: > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #51: > new file mode 100644 > > WARNING: please write a help paragraph that fully describes the config symbol > #60: FILE: drivers/soc/cirrus/Kconfig:5: > +config EP93XX_SOC > + bool "Cirrus EP93xx chips SoC" > + select SOC_BUS > + select AUXILIARY_BUS > + default y if !EP93XX_SOC_COMMON > + help > + Support SoC for Cirrus EP93xx chips. > + > > total: 0 errors, 2 warnings, 269 lines checked FWIW, I wouldn't be too worried about meeting the minimum line check for the Kconfig option that checkpatch requires - but the description here is not clear what the driver does.
Attachment:
signature.asc
Description: PGP signature
