On 08/04/2024 08:49, Mike Looijmans wrote: > The LTC3350 is a backup power controller that can charge and monitor > a series stack of one to four supercapacitors. > > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx> > --- > > .../bindings/power/supply/ltc3350.yaml | 55 +++++++++++++++++++ Missing vendor prefix, use compatible as filename. > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3350.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3350.yaml b/Documentation/devicetree/bindings/power/supply/ltc3350.yaml > new file mode 100644 > index 000000000000..607a62fd25ba > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3350.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) 2024 Topic Embedded Products > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/ltc3350.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Linear Technology (Analog Devices) LTC3350 Supercap Charger > + > +maintainers: > + - Mike Looijmans <mike.looijmans@xxxxxxxx> > + > +description: | > + The LTC3350 is a High Current Supercapacitor Backup Controller and System Just one space after 'a'. > + Monitor. > + Specifications about the charger can be found at: > + https://www.analog.com/en/products/ltc3350.html > + > +properties: > + compatible: > + enum: > + - lltc,ltc3350 > + > + reg: > + maxItems: 1 > + description: I2C address of the charger. Drop description, it is obvious. > + > + lltc,rsnsc-micro-ohms: > + description: Capacitor charger sense resistor in microohm. > + minimum: 1000 > + > + lltc,rsnsi-micro-ohms: > + description: Input current sense resistor in microohm. > + minimum: 1000 Looks like it is shunt-resistor-micro-ohms. Unless it is something different? > + > +required: > + - compatible > + - reg > + - lltc,rsnsc-micro-ohms > + - lltc,rsnsi-micro-ohms > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + charger: battery-charger@9 { > + compatible = "lltc,ltc3350"; Messed indentation. Keep it consistent. Best regards, Krzysztof
