On Mon, 8 Apr 2024 at 10:50, Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote: > > On Mon Apr 8, 2024 at 9:04 AM CEST, Luca Weiss wrote: > > On Mon Apr 8, 2024 at 9:03 AM CEST, Dmitry Baryshkov wrote: > > > On Mon, 8 Apr 2024 at 10:02, Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote: > > > > > > > > On Mon Apr 8, 2024 at 4:33 AM CEST, Dmitry Baryshkov wrote: > > > > > Populate orientation GPIOs for some of the PMIC-GLINK-based devices. > > > > > This leaves only FairPhone5, RB3Gen2, SC8180X Primus and SC8280XP CRD > > > > > without the orientation GPIOs declared. > > > > > > > > Hi Dmitry, > > > > > > > > How would I find this GPIO on the schematics, or downstream devicetree? > > > > I scanned over some relevant areas but nothing jumped out at me except > > > > for the USB_PHY_PS signal coming from PM7250B CC_OUT and going into > > > > GPIO_140 of the QCM6490 - but I'm guessing this is something else? > > > > > > It is exactly that GPIO. > > > > Great, thanks! The PM7250B datasheet and my limited USB-C knowledge > > didn't help me there much ;) > > > > I'll send a patch to add it. > > One thing I've noticed now is that the dt schema currently explicitly > disallows orientation-gpios for anything that's not sm8450, sm8550 or > x1e80100. > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: pmic-glink: orientation-gpios: False schema does not allow [[84, 140, 0]] > from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,pmic-glink.yaml# > > So I'd think also this series will cause some extra validation errors if > the schema is not adjusted? Are you planning to do that? I didn't check it. Yes, I will include it in v2. > > Regards > Luca > > > > > Regards > > Luca > > > > > > > > > > > > > Regards > > > > Luca > > > > > > > > > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > --- > > > > > Dmitry Baryshkov (4): > > > > > arm64: dts: qcom: sm8350-hdk: add USB-C orientation GPIO > > > > > arm64: dts: qcom: sm8450-hdk: add USB-C orientation GPIO > > > > > arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add USB-C orientation GPIOs > > > > > arm64: dts: qcom: sc8180x-lenovo-flex-5g: add USB-C orientation GPIOs > > > > > > > > > > arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 ++ > > > > > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 ++ > > > > > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 1 + > > > > > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 1 + > > > > > 4 files changed, 6 insertions(+) > > > > > --- > > > > > base-commit: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc > > > > > change-id: 20240408-hdk-orientation-gpios-141bc7fd247d > > > > > > > > > > Best regards, > > > > > -- With best wishes Dmitry
