On 08/04/2024 09:27, Shengjiu Wang wrote: > Convert the imx-audio-spdif binding to YAML. > > When testing dtbs_check, found below compatible strings > are not listed in document: > > fsl,imx-sabreauto-spdif > fsl,imx6sx-sdb-spdif > > So add them in yaml file to pass the test. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx> > --- > changes in v2: > - change file name to imx-spdif.yaml How does your compatible look like? fsl,imx-audio-spdif, so use that. > - remove | > - add anyof for spdif-in and spdif-out requirement > - change example name to sound > > diff --git a/Documentation/devicetree/bindings/sound/imx-spdif.yaml b/Documentation/devicetree/bindings/sound/imx-spdif.yaml > new file mode 100644 > index 000000000000..beb214b51a50 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-spdif.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-spdif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX audio complex with S/PDIF transceiver > + > +maintainers: > + - Shengjiu Wang <shengjiu.wang@xxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,imx-audio-spdif> + - enum: > + - fsl,imx-sabreauto-spdif > + - fsl,imx6sx-sdb-spdif This does not make much sense. You have mixed fallback with specific compatible. I suggest you to fix your DTS and submit proper bindings. > + - enum: > + - fsl,imx-audio-spdif > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + spdif-controller: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the i.MX S/PDIF controller > + > + spdif-out: > + type: boolean > + description: > + If present, the transmitting function of S/PDIF will be enabled, > + indicating there's a physical S/PDIF out connector or jack on the > + board or it's connecting to some other IP block, such as an HDMI > + encoder or display-controller. > + > + spdif-in: > + type: boolean > + description: > + If present, the receiving function of S/PDIF will be enabled, > + indicating there is a physical S/PDIF in connector/jack on the board. > + > +required: > + - compatible > + - model > + - spdif-controller > + > +anyOf: > + - required: > + - spdif-in > + - required: > + - spdif-out > + - required: > + - spdif-out > + - spdif-in Do you need the last required block? > + > +additionalProperties: false > + > +examples: > + - | > + sound { That's a random change... Instead of sending two patches per day, please carefully address the feedback. > + compatible = "fsl,imx-audio-spdif"; > + model = "imx-spdif"; > + spdif-controller = <&spdif>; > + spdif-out; > + spdif-in; > + }; Best regards, Krzysztof
