Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/04/2024 05:07, Mirela Rabulea wrote:
> From: Fabio Estevam <festevam@xxxxxxxxx>
> 
> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
> the PER and IPG clocks to be functional, so add the clock entries.
> 
> This also fixes the following schema warning:
> 
> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> Signed-off-by: Mirela Rabulea <mirela.rabulea@xxxxxxx>
> ---
> 

Please correct subject. You already got comments on this.
https://lore.kernel.org/linux-devicetree/2fb8c43c-c079-e04e-f727-3bc1dc29996e@xxxxxxxxxx/

> Changes since v3:
> - Add items for clocks (per Krzysztof's feddback)
> - Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
> - Add "media:" to the subject

Where? It was there before, so what did you change?


> - Add Mirela's signed-off
> - For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?
> 
> Changes since v2:
> - Remove clock-names. (Mirela)
> 
>  .../devicetree/bindings/media/nxp,imx8-jpeg.yaml   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..cc040feb77d7 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -31,6 +31,14 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  clocks:
> +    description:
> +      The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
> +      and one clock for it's core engine (AXI, same source as for the wrapper)

Description is now redundant, drop it.

> +    items:
> +      - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
> +      - description: IP bus clock for register access (ipg)
> +
>    interrupts:
>      description: |
>        There are 4 slots available in the IP, which the driver may use
> @@ -49,6 +57,7 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - clocks
>    - interrupts
>    - power-domains

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux