On 08/04/2024 07:49, Markus Burri wrote: > In the PCF2131 power management the battery switch-over function is > disabled by default. > After a power cycle the rtc clock is wrong because of that. > Add a device-tree property to configure the power management function > and enable battery switch-over. > > Signed-off-by: Markus Burri <markus.burri@xxxxxx> > --- > .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 3 +++ > drivers/rtc/rtc-pcf2127.c | 22 +++++++++++++++++++ Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > 2 files changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > index 2d9fe5a75b06..5ce0ca6dcedc 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > @@ -30,6 +30,9 @@ properties: > > reset-source: true > > + pwrmng-function: > + description: Set power management function for PCF2131 It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
