On 07/04/2024 11:09, Joy Zou wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: 2024年4月7日 17:04 >> To: Joy Zou <joy.zou@xxxxxxx>; Jacky Bai <ping.bai@xxxxxxx>; >> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; >> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx >> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx >> <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >> Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc >> PCF2131 support >>> +&lpi2c3 { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + clock-frequency = <400000>; >>> + pinctrl-names = "default", "sleep"; >>> + pinctrl-0 = <&pinctrl_lpi2c3>; >>> + pinctrl-1 = <&pinctrl_lpi2c3>; >>> + status = "okay"; >>> + >>> + pcf2131: rtc@53 { >>> + compatible = "nxp,pcf2131"; >>> + reg = <0x53>; >>> + interrupt-parent = <&pcal6524>; >>> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; >>> + status = "okay"; >> >> Really, just drop... > Ok, will drop the status in next version. > Thanks for your comment! Please read DTS coding style. Best regards, Krzysztof