On 05/04/2024 14:39, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > Add i.MX SCMI Extension protocols bindings for: > - Battery Backed Secure Module(BBSM) Which is what? > - MISC settings such as General Purpose Registers settings. > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../devicetree/bindings/firmware/imx,scmi.yaml | 80 ++++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml > new file mode 100644 > index 000000000000..7ee19a661d83 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/imx,scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX System Control and Management Interface(SCMI) Vendor Protocols Extension > + > +maintainers: > + - Peng Fan <peng.fan@xxxxxxx> > + > +allOf: > + - $ref: arm,scmi.yaml# Sorry, but arm,scmi is a final schema. Is your plan to define some common part? > + > +properties: > + protocol@81: > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + description: > + The BBM Protocol is for managing Battery Backed Secure Module (BBSM) RTC > + and the ON/OFF Key > + > + properties: > + reg: > + const: 0x81 > + > + required: > + - reg > + > + protocol@84: > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + description: > + The MISC Protocol is for managing SoC Misc settings, such as GPR settings Genera register is not a setting... this is a pleonasm. Please be more specific what is the GPR, MISC protocol etc. > + > + properties: > + reg: > + const: 0x84 > + > + wakeup-sources: > + description: > + Each entry consists of 2 integers, represents the source and electric signal edge Can you answer questions from reviewers? > + items: > + items: > + - description: the wakeup source > + - description: the wakeup electric signal edge > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + firmware { > + scmi { > + compatible = "arm,scmi"; > + mboxes = <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>; > + shmem = <&scmi_buf0>, <&scmi_buf1>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + protocol@81 { > + reg = <0x81>; > + }; > + > + protocol@84 { > + reg = <0x84>; > + wakeup-sources = <0x8000 1 > + 0x8001 1 > + 0x8002 1 > + 0x8003 1 > + 0x8004 1>; Nothing improved... If you are going to ignore reviews, then you will only get NAKed. Best regards, Krzysztof