On 4/3/24 12:44, Pavel Machek wrote: > Hi! > >> The device tree bindings define the relevant regulators for the >> sensor, so update the driver to request the regulators and control >> them at the appropriate times. > >> @@ -995,9 +1007,19 @@ static int imx258_power_on(struct device *dev) >> struct imx258 *imx258 = to_imx258(sd); >> int ret; >> >> + ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES, >> + imx258->supplies); >> + if (ret) { > > Will this make it fail for all current users? > > Best regards, > Pavel > It shouldn't affect current users as this was added in by dave for a completely different sensor and it still works on my ppp. Looking at the dmesg for imx258 it does reference the regulators that the ppp doesnt have but it still works.