Hi Sascha, Am Donnerstag, 4. April 2024, 09:27:01 CEST schrieb Sascha Hauer: > From: David Jander <david@xxxxxxxxxxx> > > The USB480M clock can source from a MUX that selects the clock to come > from either of the USB-phy internal 480MHz PLLs. These clocks are > provided by the USB phy driver. > > Signed-off-by: David Jander <david@xxxxxxxxxxx> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > drivers/clk/rockchip/clk-rk3568.c | 4 ++++ > include/dt-bindings/clock/rk3568-cru.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c > index 8cb21d10beca2..2d44bcaef046b 100644 > --- a/drivers/clk/rockchip/clk-rk3568.c > +++ b/drivers/clk/rockchip/clk-rk3568.c > @@ -215,6 +215,7 @@ static const struct rockchip_cpuclk_reg_data rk3568_cpuclk_data = { > > PNAME(mux_pll_p) = { "xin24m" }; > PNAME(mux_usb480m_p) = { "xin24m", "usb480m_phy", "clk_rtc_32k" }; > +PNAME(mux_usb480m_phy_p) = { "clk_usbphy0_480m", "clk_usbphy1_480m"}; > PNAME(mux_armclk_p) = { "apll", "gpll" }; > PNAME(clk_i2s0_8ch_tx_p) = { "clk_i2s0_8ch_tx_src", "clk_i2s0_8ch_tx_frac", "i2s0_mclkin", "xin_osc0_half" }; > PNAME(clk_i2s0_8ch_rx_p) = { "clk_i2s0_8ch_rx_src", "clk_i2s0_8ch_rx_frac", "i2s0_mclkin", "xin_osc0_half" }; > @@ -485,6 +486,9 @@ static struct rockchip_clk_branch rk3568_clk_branches[] __initdata = { > MUX(USB480M, "usb480m", mux_usb480m_p, CLK_SET_RATE_PARENT, > RK3568_MODE_CON0, 14, 2, MFLAGS), > > + MUX(USB480M_PHY, "usb480m_phy", mux_usb480m_phy_p, CLK_SET_RATE_PARENT, > + RK3568_MISC_CON2, 15, 1, MFLAGS), > + > /* PD_CORE */ > COMPOSITE(0, "sclk_core_src", apll_gpll_npll_p, CLK_IGNORE_UNUSED, > RK3568_CLKSEL_CON(2), 8, 2, MFLAGS, 0, 4, DFLAGS | CLK_DIVIDER_READ_ONLY, > diff --git a/include/dt-bindings/clock/rk3568-cru.h b/include/dt-bindings/clock/rk3568-cru.h > index d29890865150d..5263085c5b238 100644 > --- a/include/dt-bindings/clock/rk3568-cru.h > +++ b/include/dt-bindings/clock/rk3568-cru.h > @@ -78,6 +78,7 @@ > #define CPLL_333M 9 > #define ARMCLK 10 > #define USB480M 11 > +#define USB480M_PHY 12 > #define ACLK_CORE_NIU2BUS 18 > #define CLK_CORE_PVTM 19 > #define CLK_CORE_PVTM_CORE 20 > Please separate the code change and clock-id addition into separate patches. That way dt-maintainers will more easily see that there are changes to the dt-binding inside. Other than that, the change looks fine :-) Thanks Heiko