On Thu, Apr 04, 2024 at 12:00:09PM +0200, Krzysztof Kozlowski wrote: > On 04/04/2024 11:12, Siddharth Vadapalli wrote: > > On Thu, Apr 04, 2024 at 10:43:04AM +0200, Krzysztof Kozlowski wrote: > >> On 04/04/2024 10:18, Siddharth Vadapalli wrote: > >>> Add the "cpsw-mac-efuse" node within "wkup_conf" node corresponding to the > >>> CTRLMMR_MAC_IDx registers within the CTRL_MMR space. Assign the compatible > >>> "ti,am62p-cpsw-mac-efuse" to enable "syscon_regmap" operations on these > >>> registers. The MAC Address programmed in the eFuse is accessible through > >>> the CTRLMMR_MAC_IDx registers. The "ti,syscon-efuse" device-tree property > >>> points to the CTRLMMR_MAC_IDx registers, allowing the CPSW driver to fetch > >>> the MAC Address and assign it to the network interface associated with > >>> CPSW3G MAC Port 1. > >>> > >>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx> > >>> --- > >>> ... > > > > >> > >>> }; > >>> > >>> cpsw_port2: port@2 { > >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> index a84756c336d0..df9d40f64e3b 100644 > >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> @@ -18,6 +18,11 @@ chipid: chipid@14 { > >>> reg = <0x14 0x4>; > >>> bootph-all; > >>> }; > >>> + > >>> + cpsw_mac_efuse: cpsw-mac-efuse@200 { > >> > >> Node names should be generic. See also an explanation and list of > >> examples (not exhaustive) in DT specification: > >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > > I was following the convention that other mfd-syscon compatible nodes > > seemed to be using: > > https://github.com/torvalds/linux/blob/41bccc98fb7931d63d03f326a746ac4d429c1dd3/arch/arm64/boot/dts/ti/k3-am65-main.dtsi#L502 > > The node is: > > dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 > > corresponding to the compatible: > > "ti,am654-dss-oldi-io-ctrl" > > which was added by commit: > > https://github.com/torvalds/linux/commit/cb523495ee2a5938fbdd30b8a35094d386c55c12 > > So if that one was wrong, then what? I don't know really what type of > device is it, but just because one contributor called it that way, does > not mean you should keep going. Maybe investigate why that contributor > did not decide to follow Devicetree spec recommendation? Yes, it doesn't justify the convention. I seem to have picked a wrong example when figuring out the convention for naming the node. I plan to name it as: ethernet-mac-efuse while retaining the label "cpsw_mac_efuse" since CPSW is the name of the Ethernet Switch on the SoC. Please let me know if it is acceptable. I will post the v3 patch based on your feedback. Regards, Siddharth.