On Thu, 4 Apr 2024 at 11:48, Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> wrote: > > Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 > soc platforms sound card. > > The bindings are the same as for other newer Qualcomm ADSP sound cards, > thus keep them in existing qcom,sm8250.yaml file, even though Linux driver > is separate. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 2ab6871e89e5..ff1a27f26bc2 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -29,6 +29,8 @@ properties: > - enum: > - qcom,apq8016-sbc-sndcard > - qcom,msm8916-qdsp6-sndcard > + - qcom,qcm6490-sndcard > + - qcom,qcs6490-rb3gen2-sndcard My 2c: you are adding one soundcard for the SoC family (qcm6490) and another one for the particular board kind (qcs6490-rb3gen2). That doesn't seem logical. > - qcom,qrb5165-rb5-sndcard > - qcom,sc7180-qdsp6-sndcard > - qcom,sc8280xp-sndcard > -- > 2.25.1 > > -- With best wishes Dmitry