On 03/04/2024 18:20, Lorenzo Bianconi wrote: > Introduce Airoha EN7581 entry in Airoha EN7523 clock binding > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > --- > .../bindings/clock/airoha,en7523-scu.yaml | 26 +++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > index 79b0752faa91..cf893d4c74cd 100644 > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > @@ -29,10 +29,13 @@ description: | > properties: > compatible: > items: > - - const: airoha,en7523-scu > + - enum: > + - airoha,en7523-scu > + - airoha,en7581-scu > > reg: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > "#clock-cells": > description: > @@ -45,6 +48,25 @@ required: > - reg > - '#clock-cells' > > +allOf: > + - if: > + properties: > + compatible: > + const: airoha,en7523-scu > + then: > + properties: > + reg: > + maxItems: 2 > + > + - if: > + properties: > + compatible: > + const: airoha,en7581-scu > + then: > + properties: > + reg: > + maxItems: 3 Original code had here issue - lack of description of the items. You are now growing it. Please instead list the items (items: - description: foo bar .....). Best regards, Krzysztof
